Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Picker: Allow people to deselect all categories #97266

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

arthur791004
Copy link
Contributor

Related to https://github.com/Automattic/dotcom-forge/issues/10101

Proposed Changes

  • Allow people to deselect all categories

Why are these changes being made?

Testing Instructions

  • Create a new site
  • On the Goals screen, continue directly without selecting any goals
  • On the Design Picker screen,
    • Ensure the default one is Blog if no selected goals
    • Deselect all selected categories
    • Ensure it display all themes

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 changed the base branch from trunk to feat/design-picker-group-designs December 10, 2024 10:54
@arthur791004 arthur791004 self-assigned this Dec 10, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/design-picker-empty-selection on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Base automatically changed from feat/design-picker-group-designs to trunk December 11, 2024 06:12
@arthur791004 arthur791004 force-pushed the feat/design-picker-empty-selection branch 2 times, most recently from 5152c6a to 203b3ac Compare December 11, 2024 07:12
@arthur791004 arthur791004 requested a review from a team December 11, 2024 07:20
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great and code looks good 👍

@arthur791004 arthur791004 merged commit 4782432 into trunk Dec 11, 2024
16 checks passed
@arthur791004 arthur791004 deleted the feat/design-picker-empty-selection branch December 11, 2024 09:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants