Recent Feed Overhaul - Handful of CSS tweaks #97264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
eoigal
reviewed
Dec 10, 2024
I'm unable to replicate this. Looks good to me! |
|
Sorry, just realized the icons align to the left in Firefox at mobile sizes: 
|
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did one final review this morning and cleaned up 3 minor CSS issues. Head to
/read?flags=reader/recent-feed-overhaul, then review:1) Ghost SVG
When you pull up the full-page post and scroll to the bottom, if you're following the blog, you'll see an empty spot where the plus symbol should be:
Before
After
2) Two column alignment
When you pull up the two column view, the second column is currently breaking out of the default layout width:
Before
After
3) On mobile, the layout icons should be right aligned
Before
After
