Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: allow VideoPress standalone installation #97251

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

CGastrell
Copy link
Contributor

@CGastrell CGastrell commented Dec 9, 2024

Related to p1HpG7-v3V-p2

Proposed Changes

Remove feature-to-plugin mapping for VideoPress.

Why are these changes being made?

The assumption that the plugin should not be installed due to the feature being available for the user is not correct in the case of VideoPress. VideoPress standalone implements the VideoPress dashboard, which can't be found anywhere else.

p1HpG7-v3V-p2

p1733765449709419-slack-C02LK1W8T4Z

Testing Instructions

Have some AT site ready, use the calypso.live link below.

Visit the plugins section on your AT site and search for VideoPress. Access the plugin details and see the CTA "Install and activate" button is enabled. Install the plugin and confirm the process succeeds.

Look for the VideoPress entry under the Jetpack sidebar menu, click it to see the VideoPress dashboard.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@CGastrell CGastrell self-assigned this Dec 9, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 9, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
plugins                                -27 B  (-0.0%)      -13 B  (-0.0%)
marketplace                            -27 B  (-0.0%)      -13 B  (-0.0%)
jetpack-cloud-plugin-management        -27 B  (-0.0%)      -13 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/jetpack-videopress-standalone-install-at-sites on your sandbox.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
@CGastrell CGastrell added [Type] Bug [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 9, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @CGastrell! 🙌
Tested on WoA (Atomic) site, works good as described!
Also tested with a Simple site, just to make sure there are no undesired effects, and the VideoPress plugin shows up as "Requires upgrade" as expected, so we're all good there too. The code changes are all good!
LGTM! 👍

@elliottprogrammer elliottprogrammer added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 9, 2024
@CGastrell CGastrell merged commit 748e1ee into trunk Dec 9, 2024
14 of 15 checks passed
@CGastrell CGastrell deleted the fix/jetpack-videopress-standalone-install-at-sites branch December 9, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants