-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: allow VideoPress standalone installation #97251
Plugins: allow VideoPress standalone installation #97251
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~13 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @CGastrell! 🙌
Tested on WoA (Atomic) site, works good as described!
Also tested with a Simple site, just to make sure there are no undesired effects, and the VideoPress plugin shows up as "Requires upgrade" as expected, so we're all good there too. The code changes are all good!
LGTM! 👍
Related to p1HpG7-v3V-p2
Proposed Changes
Remove feature-to-plugin mapping for VideoPress.
Why are these changes being made?
The assumption that the plugin should not be installed due to the feature being available for the user is not correct in the case of VideoPress. VideoPress standalone implements the VideoPress dashboard, which can't be found anywhere else.
p1HpG7-v3V-p2
p1733765449709419-slack-C02LK1W8T4Z
Testing Instructions
Have some AT site ready, use the calypso.live link below.
Visit the plugins section on your AT site and search for VideoPress. Access the plugin details and see the CTA "Install and activate" button is enabled. Install the plugin and confirm the process succeeds.
Look for the VideoPress entry under the Jetpack sidebar menu, click it to see the VideoPress dashboard.
Pre-merge Checklist