-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Implement Pressable hosting section v3. #97236
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~399 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
f90e481
to
eca52f2
Compare
ad36efa
to
90c77f2
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
||
return ( | ||
<div className="premier-agency-hosting"> | ||
<section className="premier-agency-hosting__plan-selector-container">TODO</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is okay, a to-do for a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about a TODO
text
Other than that LGTM!
90c77f2
to
0a1ca2a
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17058006 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @jkguidaven for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
This PR implements the new Pressable hosting section v3 (feature list, Jetpack complete, testimonials, and client relationship contents).
Depends #97230
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1552
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1553
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1554
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1555
Proposed Changes
Why are these changes being made?
Testing Instructions
/marketplace/hosting/pressable
page.Pre-merge Checklist