My Home: Fix inconsistencies between the different cards on mobile

[m1r0]

Resolves #97066

Proposed Changes

• Fix some styling inconsistencies for the cards on the My Home screen, focusing mostly on mobile.
• Refactor the code and move the generic styling to an already existing class - customer-home__card. This is for cards only. Tasks (another card variant) have a more specific styling so I've skipped those.
• Use consistent breakpoints and switch to a mobile-first approach by refactoring the breakpoint-deprecated calls.
• Slightly update the style of the "Get Help" card to make it more consistent with the others.
• Fix some tasks having no padding on mobile (potentially related to Bug: My Home Black Friday card loses padding on <600px screens #96936).

Why are these changes being made?

Because once you see these issues, it's hard to unsee them. 🙂

Testing Instructions

• Checkout the branch and go to http://calypso.localhost:3000/home/YOUR-DOMAIN
• Compare the cards with http://wordpress.com/home/YOUR-DOMAIN and make sure there is an improvement (not aiming for perfection 🙂) in the paddings and style consistency on tablet and mobile. The desktop version should be mostly the same with very slight changes (mostly the "Get Help" card).
• To test cards/tasks from other views, sandbox public-api.wordpress.com, and update the get_view function in the wp-content/lib/home/views.php file to return another view. You could use the following snippet as an example:

$views = VIEWS_SIMPLE_AND_ATOMIC_TIME_SENSITIVE;
foreach ( $views as $view ) {
	return get_cards_for_view( maybe_inject_high_priority_promos( $view ), $blog_id, $user_id, $dev );
} 

• Test the other view defined at the beginning (lines 43-94) of the wp-content/lib/home/views.php file.
• Test on different browsers.

Screenshots

[Mobile Portrait] BEFORE

---

[Mobile Portrait] AFTER

---

[Mobile Landscape] BEFORE

---

[Mobile Landscape] AFTER

---

[Mobile Task Card] BEFORE

---

[Mobile Task Card] AFTER

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127041

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127041&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-127041&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/my-home-inconsistencies on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~77 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
home                                  +198 B  (+0.0%)      +62 B  (+0.0%)
checkout                               +34 B  (+0.0%)      +15 B  (+0.0%)
reader                                 +14 B  (+0.0%)      +12 B  (+0.0%)
plugins                                +14 B  (+0.0%)      +12 B  (+0.0%)
jetpack-cloud-plugin-management        +14 B  (+0.0%)      +12 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~15 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             +34 B  (+0.0%)      +15 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal        +34 B  (+0.0%)      +15 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[merkushin]

I think the staging notice has more padding than for other cards (though it is better than "before"):

As an example of "normal" padding:

[merkushin]

Looks much better now, especially on mobile.

The only inconsistency I found, I described here: #97070 (comment).
Though, I'm not sure if it is intentional or not. It looks like a special card.

[m1r0]

Thanks for the review, Dmitry!

The only inconsistency I found, I described here: #97070 (comment).
Though, I'm not sure if it is intentional or not. It looks like a special card.

Good catch! I've fixed that card as well.