Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Hide the Dataview actions on the 'Import site from WPCOM' modal. #96452

Closed

Conversation

jkguidaven
Copy link
Contributor

This PR conceals the Dataview actions in the 'Import site from WPCOM' modal.

Before After
Screenshot 2024-11-15 at 9 21 53 PM Screenshot 2024-11-15 at 9 22 16 PM

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1393

Proposed Changes

  • Utilize a CSS rule to force hide the dataview actions, as they cannot be hidden through any properties of the Dataview component.

Why are these changes being made?

  • We can omit the dataview actions in the modal since we only intend to show it as a simple table.

Testing Instructions

  • Use the A4A live link and go to the /overview page.
  • Click the Add sites dropdown button > Select Via WordPress.com.
  • Confirm that the table in the modal no longer shows the gear icon.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. A8c Agencies labels Nov 15, 2024
@jkguidaven jkguidaven requested a review from a team November 15, 2024 13:28
@jkguidaven jkguidaven self-assigned this Nov 15, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 15, 2024
@jkguidaven jkguidaven marked this pull request as ready for review November 15, 2024 13:28
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug hide/a4a/dataview-actions-on-select-site-modal on your sandbox.

@oandregal
Copy link
Contributor

I want to reshare what I've commented in this other related PR:

I recommend against hacking the library. A few weeks ago, it tooks us weeks updating the library because of them, so we should find better ways to deal with this.

There're two reasons the view config control is still visible when the consumer disabled everything (example):

  • Moving fields around. Disabling this needs a proper API in core. There was some discussion around this topic here.
  • Pagination: figure out how users can change items per page without the view config.
Screenshot 2024-11-18 at 20 35 54

I'd love to see us creating issues in core to discuss your needs and then implement them. If there are not raised anywhere, they won't get implemented. I'm happy to help making people more comfortable to prepare PRs to core.

@jkguidaven
Copy link
Contributor Author

Closing this PR for now. See my previous comment from another PR #96456 (comment)

@jkguidaven jkguidaven closed this Nov 26, 2024
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8c Agencies Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants