-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Calypso status check #92902
Add Calypso status check #92902
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
I'm happy to try that out, but if we end up using it I'd like us to make sure it's very well documented. There might be a bunch of places that need to be updated - the docs in the repo, the deployment docs in the FG (including the fact that if you're sandboxing the API, the response might be slower, and it might affect your PR merge experience), and there will have to be a PSA written to let all Calypso devs know about the change.
If I understand correctly, GitHub servers will access the endpoint, and they won't go through my sandbox. Is that right? |
That sounds correct, as long as we limit the usage of the endpoint to the GitHub action 👍 |
…alypso into add/calypso-status-check
Proposed Changes
This adds a GitHub action that checks the status of Calypso Channel on Slack. It allows us to get rid of this Tampermonkey script and its quirks. Also, not everyone is aware of this script.
Testing Instructions
Blocked by: D156224-code
act
, it's very straightforward.curl --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/nektos/act/master/install.sh | sudo bash
.act -P ubuntu-latest=catthehacker/ubuntu:act-latest merge_group -s CALYPSO_CHANNEL_STATUS_API_SECRET=PING ME FOR THE SECRET
.Next steps