Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calypso status check #92902

Merged
merged 12 commits into from
Jul 25, 2024
Merged

Add Calypso status check #92902

merged 12 commits into from
Jul 25, 2024

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Jul 23, 2024

Proposed Changes

This adds a GitHub action that checks the status of Calypso Channel on Slack. It allows us to get rid of this Tampermonkey script and its quirks. Also, not everyone is aware of this script.

Testing Instructions

Blocked by: D156224-code

  1. To install GH actions locally, you can use act, it's very straightforward.
  2. In Calypso repo's root, install act by running curl --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/nektos/act/master/install.sh | sudo bash.
  3. Run the action by running act -P ubuntu-latest=catthehacker/ubuntu:act-latest merge_group -s CALYPSO_CHANNEL_STATUS_API_SECRET=PING ME FOR THE SECRET.
  4. Sadly, you can't test the endpoint unless it's deployed because Docker requires a business account to use SOCKS proxy (i.e access your sandbox).

Next steps

  1. Enable merge queue.

@matticbot
Copy link
Contributor

matticbot commented Jul 23, 2024

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@alshakero alshakero requested a review from a team July 24, 2024 10:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 24, 2024
@matticbot
Copy link
Contributor

matticbot commented Jul 24, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/calypso-status-check on your sandbox.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

I'm happy to try that out, but if we end up using it I'd like us to make sure it's very well documented. There might be a bunch of places that need to be updated - the docs in the repo, the deployment docs in the FG (including the fact that if you're sandboxing the API, the response might be slower, and it might affect your PR merge experience), and there will have to be a PSA written to let all Calypso devs know about the change.

@alshakero
Copy link
Member Author

including the fact that if you're sandboxing the API, the response might be slower

If I understand correctly, GitHub servers will access the endpoint, and they won't go through my sandbox. Is that right?

@tyxla
Copy link
Member

tyxla commented Jul 24, 2024

including the fact that if you're sandboxing the API, the response might be slower

If I understand correctly, GitHub servers will access the endpoint, and they won't go through my sandbox. Is that right?

That sounds correct, as long as we limit the usage of the endpoint to the GitHub action 👍

alshakero added a commit that referenced this pull request Jul 25, 2024
@alshakero alshakero marked this pull request as ready for review July 25, 2024 11:45
@alshakero alshakero merged commit c3ff395 into trunk Jul 25, 2024
10 checks passed
@alshakero alshakero deleted the add/calypso-status-check branch July 25, 2024 11:47
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2024
alshakero added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants