Assembler: Unset white background

[taipeicoder]

Fixes #89324

Proposed Changes

This PR fixes the issue where the background colors from global styles are not applied in the block renderer in the Assembler. This is caused by https://github.com/WordPress/gutenberg/pull/59377/files, where the background is explicitly set to white.

Note that the issue only affects Safari.

Testing Instructions

1. Using Safari, head to the Assembler.
2. Select some patterns, then styles.
3. Ensure that the background color from the global styles is applied correctly to the pattern in the large preview.
4. Ensure that Chrome and Safari also works as before.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-4f431f73022b48f06805461aecbda9e91c084b33

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-4f431f73022b48f06805461aecbda9e91c084b33&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-4f431f73022b48f06805461aecbda9e91c084b33&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~46 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
patterns           +64 B  (+0.0%)      +24 B  (+0.0%)
import-flow        +64 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[arthur791004]

Tested and looks good to me!

Before	After

[arthur791004]

Oh but it doesn't work on the preview of the pattern list

[taipeicoder]

Oh but it doesn't work on the preview of the pattern list

@arthur791004 do you mean the pattern list in the sidebar? I don't remember the global styles being applied there before...

[arthur791004]

It did work on other browsers, e.g.: Edge

[arthur791004]

But I think we can move this forward and address it later 🙂

[taipeicoder]

Seems that there's already a fix in WordPress/gutenberg#60106, which is available in @wordpress/block-editor 12.23.0. Currently, the version in Calypso is 12.22.0.

@tyxla do you know if/when the next wordpress/* packages dependency update is scheduled for? Or is it something we can request? Thanks in advance!

[taipeicoder]

Closing this PR as I consider updating the wordpress packages is a more robust solution to this issue.

[tyxla]

@tyxla do you know if/when the next wordpress/* packages dependency update is scheduled for? Or is it something we can request? Thanks in advance!

For some reason, renovate never came up with it. I was away last week, but I'll be taking a look at it this week.

[tyxla]

We've updated the @wordpress packages to the latest ones: #89640

[taipeicoder]

We've updated the @wordpress packages to the latest ones: #89640

Nice! Thanks so much for the update.