Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler - Remove blockGap between header/sections/footer in new assembler theme #80212

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

miksansegundo
Copy link
Contributor

@miksansegundo miksansegundo commented Aug 4, 2023

Related to #78097

Proposed Changes

Remove the block gap between:

  • header and footer patterns in the assembler large preview
  • section patterns in the assembler large preview and the editor and front-end

Notes

  • Users still can add margins between patterns or change the block gap from the editor

Follow-up tasks

Assembler Large Preview

BEFORE AFTER
Screenshot 2566-08-04 at 14 06 28 Screenshot 2566-08-04 at 14 06 06

Site Editor

BEFORE AFTER
Screenshot 2566-08-04 at 14 10 33 Screenshot 2566-08-04 at 14 09 23

Testing Instructions

  • Access the assembler /setup/with-theme-assembler/patternAssembler?siteSlug={ YOUR SITE }
  • Add a header, two section patterns, and a footer. Choose patterns with a background color, not white background, so it's easier to see if there are gaps
  • Verify that there aren't gaps between patterns in the assembler large preview
  • Click "Continue" and you will land on the editor
  • Verify you still see gaps between header and footer patterns in the editor
  • Sandbox your site and the public API
  • Go to the folder /wpcom/public_html/wp-content/themes/pub in your sandbox and checkout the PR Creatio - Remove blockGap between first-level patterns themes#7288
    • Alternatively you can manually edit the file on your sandbox
  • Refresh the editor to confirm that there aren't gaps between header and footer patterns

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@miksansegundo miksansegundo requested a review from a team August 4, 2023 07:22
@miksansegundo miksansegundo self-assigned this Aug 4, 2023
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 4, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~25 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +37 B  (+0.0%)      +25 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~54 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
pattern-assembler-step        -76 B  (-0.0%)      -10 B  (-0.0%)
import-flow                   -76 B  (-0.0%)      -10 B  (-0.0%)
subscribers                   +37 B  (+0.0%)      +21 B  (+0.0%)
sites-dashboard               +37 B  (+0.0%)      +21 B  (+0.0%)
site-purchases                +37 B  (+0.0%)      +21 B  (+0.0%)
settings                      +37 B  (+0.0%)      +21 B  (+0.0%)
purchases                     +37 B  (+0.0%)      +21 B  (+0.0%)
hosting                       +37 B  (+0.0%)      +21 B  (+0.0%)
home                          +37 B  (+0.0%)      +21 B  (+0.0%)
email                         +37 B  (+0.0%)      +22 B  (+0.0%)
domains                       +37 B  (+0.0%)      +21 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~42 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-masterbar-help-center         +37 B  (+0.1%)      +21 B  (+0.2%)
async-load-design                        +37 B  (+0.0%)      +21 B  (+0.0%)
async-load-automattic-help-center        +37 B  (+0.0%)      +21 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good 👍

@miksansegundo miksansegundo merged commit 68176ea into trunk Aug 8, 2023
@miksansegundo miksansegundo deleted the fix/assembler-blockgap-between-patterns branch August 8, 2023 05:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants