Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: remove the need for postId and postTemplate args #76047

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

mattwiebe
Copy link
Contributor

@mattwiebe mattwiebe commented Apr 20, 2023

Now that WordPress/gutenberg#49861 has landed on wpcom, we can remove our workaround of adding the query args ourselves.

Related to #75183 and WordPress/gutenberg#49861

Proposed Changes

  • Remove the call to /sites/SITE/block-editor in the /site-editor/SITE redirect.
  • The wpcom request was also generating some improperly-handled errors, so good to get rid of it.

Testing Instructions

Try accessing /site-editor/SITE with this branch built. You should see no query args in the redirected Site Editor URL (other than calypso_origin if running locally).

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Now that WordPress/gutenberg#49861 has landed on wpcom, we can remove our workaround of adding the query args ourselves.
@mattwiebe mattwiebe added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg [Goal] Full Site Editing labels Apr 20, 2023
@mattwiebe mattwiebe requested review from fullofcaffeine and a team April 20, 2023 16:29
@github-actions
Copy link

github-actions bot commented Apr 20, 2023

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~40 bytes removed 📉 [gzipped])

name              parsed_size           gzip_size
gutenberg-editor       -134 B  (-0.0%)      -40 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mattwiebe mattwiebe self-assigned this Apr 20, 2023
@mattwiebe mattwiebe merged commit 3708c73 into trunk Apr 20, 2023
@mattwiebe mattwiebe deleted the remove/site-editor-home-template-args branch April 20, 2023 21:15
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Full Site Editing [Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants