Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Data Stores: Refactor partner portal credit card store to createReduxStore()" #75371

Merged

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Apr 6, 2023

Reverts #74656

We are reverting this PR as users are unable to add cards as payment methods.

Testing Instructions

Instructions

  1. Run git checkout revert-74656-refactor/partner-portal-credit-card-store and yarn start-jetpack-cloud
  2. Visit http://jetpack.cloud.localhost:3000/partner-portal/payment-methods
  3. Click the Add new credit card button.
  4. Enter the card details and the Save payment method button
  5. Verify the added card is saved successfully.

@yashwin yashwin requested review from vitozev and tyxla April 6, 2023 07:15
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 6, 2023
@yashwin yashwin self-assigned this Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~37 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
jetpack-cloud-partner-portal        +30 B  (+0.0%)      -37 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin merged commit 41abfc9 into trunk Apr 6, 2023
@yashwin yashwin deleted the revert-74656-refactor/partner-portal-credit-card-store branch April 6, 2023 07:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 6, 2023
@tyxla
Copy link
Member

tyxla commented Apr 6, 2023

Thanks for taking care of the revert. I'll double-check that scenario in the next take.

tyxla added a commit that referenced this pull request Apr 6, 2023
@tyxla
Copy link
Member

tyxla commented Apr 6, 2023

Second take is here: #75377

tyxla added a commit that referenced this pull request Apr 7, 2023
…xStore()` - take 2 (#75377)

* Revert "Revert "Data Stores: Refactor partner portal credit card store to createReduxStore() (#74656)" (#75371)"

This reverts commit 41abfc9.

* Access store directly, rely on type inference

* Remove unnecessary mocks to fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants