Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Stores: Remove unused i18n store #75279

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 4, 2023

Proposed Changes

This PR removes the i18n store that we are no longer using since #74475.

Testing Instructions

  • Verify the removed store is no longer in use.
  • Verify all checks are green.

@tyxla tyxla added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. i18n [Type] Janitorial Data-Store labels Apr 4, 2023
@tyxla tyxla requested review from a team April 4, 2023 13:26
@tyxla tyxla self-assigned this Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@yuliyan yuliyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tyxla tyxla force-pushed the remove/unused-i18n-data-store branch from bc62cb9 to b179cc9 Compare April 5, 2023 12:01
@tyxla tyxla merged commit f4833dd into trunk Apr 5, 2023
@tyxla tyxla deleted the remove/unused-i18n-data-store branch April 5, 2023 12:26
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants