Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Stores: migrate Subscriber store to createReduxStore #74430

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Data Stores: migrate Subscriber store to createReduxStore #74430

merged 3 commits into from
Mar 16, 2023

Conversation

flootr
Copy link
Contributor

@flootr flootr commented Mar 14, 2023

Proposed Changes

This PR migrates the Subscriber store to use createReduxStore() and register() instead of registerStore().

Part of #74399 which is a follow-up to #73890.

Testing Instructions

  • Go to /people/subscribers/:siteSlug and hit Add subscriber
  • Add subscribers to your site by using the form as well as the CSV import
  • Make sure everything works exactly as on prod

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@flootr flootr self-assigned this Mar 14, 2023
@flootr flootr mentioned this pull request Mar 14, 2023
Open
40 tasks
@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-60326
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-60326&env=jetpack

@flootr flootr force-pushed the migrate/subscriber-store-create-redux-store branch 2 times, most recently from 8ba7c59 to ad158e5 Compare March 15, 2023 11:00
@flootr flootr force-pushed the migrate/subscriber-store-create-redux-store branch from b156ddb to f553f85 Compare March 16, 2023 08:07
@matticbot
Copy link
Contributor

matticbot commented Mar 16, 2023 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~20 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
people                 +28 B  (+0.0%)      -12 B  (-0.0%)
newsletter-flow        +28 B  (+0.0%)       -8 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@flootr flootr marked this pull request as ready for review March 16, 2023 08:25
@flootr flootr requested review from noahtallen, bogiii and a team March 16, 2023 08:25
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 16, 2023
@flootr flootr requested a review from tyxla March 16, 2023 08:25
tyxla
tyxla approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @flootr 🙌

packages/data-stores/src/subscriber/types.ts Outdated Show resolved Hide resolved
packages/data-stores/src/index.ts
@@ -30,7 +30,6 @@ export * from './templates';
export * from './onboard/types';
export * from './domain-suggestions/types';
export * from './plans/types';
export * from './subscriber/types';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, those are already exported as Subscriber. types and consumed only that way 👍

bogiii
bogiii approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and all works as expected. 👌

@flootr flootr force-pushed the migrate/subscriber-store-create-redux-store branch from f553f85 to 2c4d57f Compare March 16, 2023 13:28
@flootr flootr merged commit 670903f into trunk Mar 16, 2023
@flootr flootr deleted the migrate/subscriber-store-create-redux-store branch March 16, 2023 13:53
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@bogiii bogiii bogiii approved these changes

@noahtallen noahtallen Awaiting requested review from noahtallen

Assignees

@flootr flootr

Labels
Data-Store Subscriber Importer [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flootr @matticbot @bogiii @tyxla