Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused data store #74395

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Remove unused data store #74395

merged 1 commit into from
Mar 14, 2023

Conversation

noahtallen
Copy link
Contributor

@noahtallen noahtallen commented Mar 13, 2023

See #74399 for more info

Proposed Changes

As I was working on migrating some data stores to createReduxStore, I found that this data store (automattic/whats-new) is never used anywhere. It appears we migrated to using inline state instead.

Testing Instructions

  • sync ETK to your sandbox and sandbox a test site.
  • When loading the editor verify that the "what's new" feature works (it's available in the three-dot dropdown menu in the top-right.)

@noahtallen noahtallen self-assigned this Mar 13, 2023
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit remove-unused-whatsnew-store on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@noahtallen noahtallen requested a review from a team March 13, 2023 23:13
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 13, 2023
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

FWIW the @automattic/whats-new package is responsible for that functionality, and it now uses react query so even if that store was considered to be used, I don't think it will be.

🚀

@noahtallen noahtallen merged commit 2b11798 into trunk Mar 14, 2023
@noahtallen noahtallen deleted the remove-unused-whatsnew-store branch March 14, 2023 19:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants