Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Visually fix file download link in reader full post page #73203

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

roo2
Copy link
Contributor

@roo2 roo2 commented Feb 10, 2023

Part of #43595

Currently the "File" block looks slightly broken, this tiny PR gives it a little tidy up and hides the unnecessary "Download" button

Before

Screen Shot 2023-02-10 at 2 55 43 pm

After

Screen Shot 2023-02-10 at 2 55 38 pm

Testing instructions

Example site https://wordpress.com/read/blogs/159889361/posts/1219

@roo2 roo2 requested a review from a team as a code owner February 10, 2023 05:00
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 10, 2023
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 it.

@roo2 roo2 merged commit a526519 into trunk Feb 13, 2023
@roo2 roo2 deleted the fix/reader-hide-file-download-button branch February 13, 2023 01:29
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants