Try: Upgrade @wordpress packages to pre-React 18

[tyxla]

This PR aims to upgrade the @wordpress packages to versions before upgrading to React 18.

Still in progress and very far from ready.

DO NOT MERGE.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-58284

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-58284&env=jetpack

[matticbot]

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit try/upgrade-wordpress-packages-pre-react18 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

[matticbot]

This PR modifies the release build for wpcom-block-editor

To test your changes on WordPress.com, run install-plugin.sh wpcom-block-editor try/upgrade-wordpress-packages-pre-react18 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-l4k-p2

[noahtallen]

Ah, I remember starting to look at some of these. I think the big change is that @wordpress/data now bundles its own types. As a result, we can remove @types/wordpress__data, but this also means we have to rework how we define types for some of our data stores.

Essentially, the issue Cannot redeclare block-scoped variable 'select'. happens because we use declare module '@wordpress/data' to provide our own types for data stores currently (along with registerStore). But registerStore has been deprecated now in favor of register, which I think allows types to work successfully without declaring the module ourselves.

Once I tried switching from registerStore to register, I recall an issue with the persistence plugin, which was never updated to handle the newer API

At that point, I had some other priorities so I didn't get a chance to follow-up.

[tyxla]

Yup 👍 What you said, essentially. I'm happy to give it a try and see where it goes. Will ping you when I get it closer 😉

[tyxla]

This got way messier than I was hoping it to be. I'm going to close it and retry another time. Maybe we should do it in smaller chunks of versions and not with such a huge leap forward.

[arthur791004]

Okay! I'll continue on #73078 to see how it works 🙂

[tyxla]

Thanks, @arthur791004. I've also left some thoughts in #73629 (comment) in case that helps your scenario.

[tyxla]

I've started work on a second take in #73890 and will be working on it this week.