Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade wordpress monorepo #69448

Closed
wants to merge 5 commits into from
Closed

Upgrade wordpress monorepo #69448

wants to merge 5 commits into from

Conversation

noahtallen
Copy link
Contributor

@noahtallen noahtallen commented Oct 25, 2022 •
edited
Loading

Proposed Changes

Upgrade WordPress monorepo to the latest version:

  • Add the upgrade-interactive yarn plugin. (This accounts for 541 lines of the diff -- so we're really only adding around 300 lines in this PR, not 800.)
  • Ran that to upgrade every WordPress and @types/wordpress package.
  • Fixed peer dependency resolutions in yarnrc.yml.
  • Deduped dependencies.
  • TBD to fix errors that arise

Testing Instructions

  1. Smoke test calypso.live, especially any WordPress components. Test components in devdocs as well.
  2. Verify local yarn install and yarn build continue to work as expected.
  3. Smoke test ETK.

@noahtallen noahtallen requested review from a team and worldomonation as code owners October 25, 2022 20:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 25, 2022
@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-47254
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-47254&env=jetpack

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit upgrade-wordpress-monorepo on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for notifications

To test your changes on WordPress.com, run install-plugin.sh notifications upgrade-wordpress-monorepo on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-elI-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for o2-blocks

To test your changes on WordPress.com, run install-plugin.sh o2-blocks upgrade-wordpress-monorepo on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

worldomonation
worldomonation approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@worldomonation worldomonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you've met your LoC quota for the week!

In all seriousness, approving to unblock once all tasks pass reliably and staging has no issues.

@noahtallen
Copy link
Contributor Author

noahtallen commented Oct 25, 2022 •
edited
Loading

Thanks! Unfortunately, looks like we'll need to do some refactoring of our data stores to get typescript to compile.

Edit: more on the wp/data issue here if anyone has advice: p1666742659923809-slack-C45SNKV4Z

yuliyan
yuliyan reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@yuliyan yuliyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested @wordpress/i18n and @wordpress/react-i18n and didn't see any problems.

@noahtallen
Copy link
Contributor Author

#73890 superseded this

@noahtallen noahtallen closed this Mar 14, 2023
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 14, 2023
@tyxla tyxla deleted the upgrade-wordpress-monorepo branch March 15, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliyan yuliyan yuliyan left review comments

@worldomonation worldomonation worldomonation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noahtallen @matticbot @yuliyan @worldomonation