Update ETK phpunit to work with new wp-env improvements #65653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
does not work on M1, etc.
noahtallen
force-pushed
the
update-etk-phpunit-wp-env
branch
from
c6ebf10 to
c895c30
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In WordPress/gutenberg#41780 and WordPress/gutenberg#41852 @ObliviousHarmony made some improvements to wp-env we can take advantage of in Calypso:
phpunitcontainer was deprecated upstream. We can control the phpunit version ourselves with composer. Since this container was also broken on M1 machines, not using it will fix that issue.This shouldn't be merged until the wp-env update is available on npm.
Testing Instructions
Run
$ path/to/gutenberg/packages/env/bin/wp-env run tests-wordpress /var/www/html/wp-content/plugins/editing-toolkit-plugin/vendor/bin/phpunit -c /var/www/html/wp-content/plugins/editing-toolkit-plugin/phpunit.xml.dist --verboseand it should pass.