Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licensing portal: Rename the existing payment methods state #61583

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Licensing portal: Rename the existing payment methods state #61583

merged 3 commits into from
Mar 2, 2022

Conversation

vitozev
Copy link
Contributor

@vitozev vitozev commented Mar 1, 2022

Changes proposed in this Pull Request

Rename the existing payment-methods state to match the actual behavior. In this code, we are not describing the payment methods but the logic around adding a new credit card form.

Testing instructions

  • If you do not have a partner key, please get in touch with Avalon for one, or you will be unable to view the UI.
  • Checkout PR locally, run yarn && yarn start-jetpack-cloud.
  • Visit http://jetpack.cloud.localhost:3000/partner-portal/payment-methods and select your partner key, if prompted.
  • Click the “Add new credit card” button.
  • Verify that the form is displayed and no errors are shown in the console

@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-28403
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-28403&env=jetpack

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

manzoorwanijk
manzoorwanijk approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vitozev vitozev added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 2, 2022
@vitozev vitozev merged commit 1e44275 into trunk Mar 2, 2022
@vitozev vitozev deleted the update/licensing-portal-rename-payment-methods-store branch March 2, 2022 07:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 2, 2022
@tyxla tyxla mentioned this pull request Mar 20, 2023
Merged
7 tasks
@tyxla tyxla mentioned this pull request Apr 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manzoorwanijk manzoorwanijk manzoorwanijk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitozev @matticbot @manzoorwanijk