Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Log: Refactor QueryRewindBackupStatus away from UNSAFE_ methods #61115

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Feb 15, 2022

Changes proposed in this Pull Request

This PR migrates the QueryRewindBackupStatus component away from the UNSAFE_ deprecated React component methods.

Part of #58453.

Testing instructions

  • Go to /activity-log/:site where :site is an Atomic site with backups that have been enabled for a while.
  • Verify you can still "Download" a backup.
  • Verify that when you click "Create download", it still tracks progress accurately until it succeeds.
  • Verify that after you refresh the page, you still see the successful backup to download.

@tyxla tyxla added [Type] Enhancement Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Rewind [Feature] Activity Log labels Feb 15, 2022
@tyxla tyxla requested a review from a team February 15, 2022 12:14
@tyxla tyxla self-assigned this Feb 15, 2022
@matticbot
Copy link
Contributor

matticbot commented Feb 15, 2022

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@flootr flootr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as described 👍🏻

@tyxla tyxla merged commit d2f01f1 into trunk Feb 15, 2022
@tyxla tyxla deleted the refactor/query-rewind-backup-status-unsafe branch February 15, 2022 12:40
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants