Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Woop installer: restore autotransferring handling #58811

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Woop installer: restore autotransferring handling #58811

merged 3 commits into from
Dec 3, 2021

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Dec 3, 2021 •
edited
Loading

Changes proposed in this Pull Request

This PR restores the automatic skip to the transfer step when the site has the proper state.

Testing instructions

Confirm that when:

  • It's a Simple site
  • With a custom domain
  • With a Biz plan
  • Without blockers

... it skips the confirm step transferring the site on the fly.

Screen.Recording.2021-12-03.at.11.36.55.AM.mov
Screen.Recording.2021-12-03.at.5.23.27.PM.mov

Related to #

@retrofox retrofox added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Size] S Small sized issue Woop WooCommerce on Plans Pod labels Dec 3, 2021
@retrofox retrofox requested a review from a team December 3, 2021 14:38
@retrofox retrofox self-assigned this Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited by matticbot
Loading

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-21309
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-21309&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Dec 3, 2021 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
signup       +248 B  (+0.1%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~776 bytes removed 📉 [gzipped])

name                                                  parsed_size            gzip_size
async-load-signup-steps-woocommerce-install-transfer     +14810 B  (+14.0%)    +4672 B  (+14.0%)
async-load-signup-steps-woocommerce-install-confirm         +58 B   (+0.1%)      +21 B   (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@retrofox retrofox force-pushed the update/woop-move-automatically-to-transfer-step branch 2 times, most recently from 4ca39d4 to d435457 Compare December 3, 2021 14:58
@DustyReagan
Copy link
Member

DustyReagan commented Dec 3, 2021 •
edited
Loading

This flow is working for me.

I did notice once the transfer is finished I get a "Sorry, you are not allowed to access this page” error. If I refresh the page, it shows me the Woo setup correctly.

My video framing is a little off, sorry.

working.mp4

@retrofox
Copy link
Contributor Author

retrofox commented Dec 3, 2021

I did notice once the transfer is finished I get a "Sorry, you are not allowed to access this page” error. If I refresh the page, it show me the Woo setup correctly.

I think that's an AT known issue :-/. And I think it should in the trunk. It happens when it tries to redirect to the wp-admin. It belongs to the transferring step.
That's what we've been working on the new endpoint using post transfer hook.

DustyReagan
DustyReagan approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@retrofox retrofox force-pushed the update/woop-move-automatically-to-transfer-step branch from d435457 to 904c883 Compare December 3, 2021 20:22
@DustyReagan
Copy link
Member

New commit working well! Have not seen "Sorry, you are not allowed to access this page” error.

woo-install.mov

@retrofox retrofox merged commit c1bf48f into trunk Dec 3, 2021
@retrofox retrofox deleted the update/woop-move-automatically-to-transfer-step branch December 3, 2021 21:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2021
nelsonec87 pushed a commit that referenced this pull request Dec 9, 2021
@retrofox @nelsonec87
Woop installer: restore autotransferring handling (#58811)
83a56f3 
* woop: restore autotransferring handling

* woop: fetch status in transfer step

* woop: add delay before redirect after transferring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustyReagan DustyReagan DustyReagan approved these changes

Assignees

@retrofox retrofox

Labels
[Size] S Small sized issue [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Woop WooCommerce on Plans Pod
Projects
Woo on Plans
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@retrofox @matticbot @DustyReagan