Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: Remove Doyle design temporarily due to issue with Alves theme and that design #48723

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

andrewserong
Copy link
Member

Changes proposed in this Pull Request

Once the issue is resolved in Alves, we can add Doyle back to the list of designs.

Testing instructions

  • Go to /new and on the design selection step ensure that the Doyle design does not appear for selection. E.g. you should not see the following in the list:

image

  • Make sure that selecting any other design works and you can still create a site

Fixes #

@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2021
@andrewserong andrewserong requested review from a team January 7, 2021 23:04
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~23 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       -196 B  (-0.0%)      -23 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@andrewserong andrewserong self-assigned this Jan 8, 2021
Copy link
Contributor

@autumnfjeld autumnfjeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that Doyle does not show up in /new signup process

Screen Shot 2021-01-08 at 11 56 57

Able to successfully create a site with another design. 👍

@andrewserong andrewserong merged commit e4f9c37 into trunk Jan 8, 2021
@andrewserong andrewserong deleted the fix/remove-doyle-design branch January 8, 2021 01:03
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants