-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding: Add support for RTL site launch stylesheet to ETK #47890
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D53548-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do you know why "Select a domain" isn't being translated? The translation exists, I'm thinking maybe a timing issue with the initial render.
That's this issue #47884 @lsl But what do you mean about the translation exists? When I look up translate.wordpress.org I don't see it 😕 Have I been looking in the wrong place for ETK strings? |
Oh I checked .com, it's a string from 2016, are we getting etk translations from .org? |
@lsl yes that's my understanding (afaik, I've been working with that assumption and nothing's contradicted it yet). My guess is that makes it easiest to deliver the translations to atomic. |
Changes proposed in this Pull Request
is_rtl()
Copying prior art for how this is done in the ETK plugin:
wp-calypso/apps/editing-toolkit/editing-toolkit-plugin/dotcom-fse/class-full-site-editing.php
Line 139 in 961a9bd
wp-calypso/apps/editing-toolkit/editing-toolkit-plugin/common/index.php
Line 131 in 961a9bd
Before
(see how the margins are all strange)
After
(also includes the fix from #47889)
Testing instructions
yarn dev --sync
and sandbox an un-launched siteeditor-site-launch.rtl.css
is being loaded and the non-rtl file isn't