-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gutenboarding to use new <LocaleProvider> #47567
Update Gutenboarding to use new <LocaleProvider> #47567
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~190 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM depends deploy of #47570 so we avoid pulling i18n-calypso to anything we don't want to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#47570 deployed, probably a good idea to rebase this
15a9dbf
to
eb95216
Compare
Split from #47446
Changes proposed in this Pull Request
react-i18n
toi18n-utils
For the reasons outlined in #47566 the locale slug shouldn't come from
react-i18n
. This PR migrates gutenboarding away from that package.Testing instructions
Test that all the gutenboarding locale features are working just like before
/new
should be in the current users language/new/fr
should show the UI in french/new/fr
and create a new user. The language of the new account should be set to French