Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gutenboarding to use new <LocaleProvider> #47567

Conversation

p-jackson
Copy link
Member

Split from #47446

Changes proposed in this Pull Request

  • Switch gutenboarding from getting the locale slug from react-i18n to i18n-utils

For the reasons outlined in #47566 the locale slug shouldn't come from react-i18n. This PR migrates gutenboarding away from that package.

Testing instructions

Test that all the gutenboarding locale features are working just like before

  • The UI at /new should be in the current users language
  • /new/fr should show the UI in french
  • The plans grid and domain picker should be translated correctly
  • Using an incognito window, go throught the flow starting from /new/fr and create a new user. The language of the new account should be set to French

@p-jackson p-jackson requested a review from lsl November 19, 2020 03:46
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2020
@p-jackson p-jackson self-assigned this Nov 19, 2020
@p-jackson p-jackson added [Goal] New Onboarding previously called Gutenboarding i18n labels Nov 19, 2020
@matticbot
Copy link
Contributor

matticbot commented Nov 19, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~190 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       +652 B  (+0.0%)     +190 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@lsl lsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM depends deploy of #47570 so we avoid pulling i18n-calypso to anything we don't want to.

@lsl lsl mentioned this pull request Nov 20, 2020
46 tasks
Copy link
Contributor

@lsl lsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#47570 deployed, probably a good idea to rebase this

@p-jackson p-jackson force-pushed the update/gutenboarding-use-locale-provider-instead-of-react-i18n branch from 15a9dbf to eb95216 Compare November 20, 2020 01:40
@p-jackson p-jackson merged commit 3a3d26f into master Nov 20, 2020
@p-jackson p-jackson deleted the update/gutenboarding-use-locale-provider-instead-of-react-i18n branch November 20, 2020 02:03
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] New Onboarding previously called Gutenboarding i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants