Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert calypso localizeUrl's move to i18n-utils package #47564

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Nov 19, 2020

Reverts localizeUrl to its state prior to the move to i18n-utils package.

This is an intermediate PR, to make deploying the changes needed in #47492 a bit easier.

Testing instructions

@lsl lsl added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2020
@lsl lsl requested a review from p-jackson November 19, 2020 01:04
@lsl lsl self-assigned this Nov 19, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~352 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-main                  -291 B  (-0.0%)      -95 B  (-0.0%)
entry-login                 -291 B  (-0.0%)      -86 B  (-0.0%)
entry-gutenboarding         -291 B  (-0.0%)      -80 B  (-0.0%)
entry-domains-landing       -291 B  (-0.1%)      -91 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think I thought you would also revert all of the changes to i18n-utils that were made in #46998, but I guess there's no point since you're going to continue deving there.

@lsl lsl merged commit 7cd1d68 into master Nov 19, 2020
@lsl lsl deleted the update/revert-localizeUrl branch November 19, 2020 02:18
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants