-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans: scroll to the top when moving across pages #45933
Conversation
useEffect( () => { | ||
window.scrollTo( 0, 0 ); | ||
}, [] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reset the scroll just after the first render.
useEffect( () => { | ||
window.scrollTo( 0, 0 ); | ||
}, [] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reset the scroll just after the first render.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~109 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, works great. A much better experience, indeed!
LGTM! 👍
Changes proposed in this Pull Request
Testing instructions
/plans/:site
.Fixes 1169247016322522-as-1193973893888697
Demo
Before
After