fix(ci): restore CONFIG_ENV variable #45589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
nsakaimbo
force-pushed
the
desktop-fix-config-env
branch
from
40ed338 to
6ae9115
Compare
mokagio
approved these changes
Sep 14, 2020
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restores the
CONFIG_ENVvariable, which was erroneously dropped during migration from the wp-desktop repo. Omitting this variable results in failure to create a valid auto-updater config.Unfortunately this part of the build process has been silently failing as the failure case in the
try/catchlogic of the supporting node script was not logged to the console (meaning that the auto-updater included in builds published to this repo so far have been invalid). 😞