Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: style Gutenberg latest post block #44295

Conversation

tophertoy
Copy link
Contributor

@tophertoy tophertoy commented Jul 21, 2020

Changes proposed in this Pull Request

This PR deals with just the latest post block from issue: #43595
Working from: https://made4testing0318.blog/2020/04/16/latest-posts-block/

Testing instructions

Taken from: http://calypso.localhost:3000/read/blogs/159889361/posts/1003

Before:
Screenshot 2020-07-21 12 49 41

After:

Screenshot 2020-08-06 16 07 22

@tophertoy tophertoy force-pushed the fix/43595-ensure-reader-latest-post-block-match-main-site-styles branch 2 times, most recently from 1d43c13 to aa23d6b Compare July 23, 2020 04:27
@tophertoy tophertoy force-pushed the fix/43595-ensure-reader-latest-post-block-match-main-site-styles branch from aa23d6b to 92e6496 Compare July 23, 2020 04:30
@tophertoy
Copy link
Contributor Author

@bluefuton thoughts so far?

@tophertoy tophertoy marked this pull request as ready for review July 23, 2020 04:34
@tophertoy tophertoy requested a review from a team as a code owner July 23, 2020 04:34
@bluefuton bluefuton added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Reader The reader site on Calypso. labels Jul 31, 2020
@bluefuton bluefuton changed the title Style latest post block in reader to match main site (https://github.… Reader: style Gutenberg latest post block Jul 31, 2020
@tophertoy tophertoy requested a review from bluefuton August 6, 2020 04:07
@bluefuton
Copy link
Contributor

Much improved 👍

Can we investigate what happens with featured images? I notice the penguins on this post are misaligned:

http://calypso.localhost:3000/read/blogs/159889361/posts/760

Screen Shot 2020-08-06 at 16 26 15

@tophertoy
Copy link
Contributor Author

@bluefuton yes I can do that.

I noticed it's in production too: https://wordpress.com/read/blogs/159889361/posts/760

Screen Shot 2020-08-10 at 3 29 02 PM

What is the preferred Automattic process to proceed with a production fix?

Do you normally check if someone has raised an issue first and see if anyone is working on it?

@bluefuton
Copy link
Contributor

What is the preferred Automattic process to proceed with a production fix?

@tophertoy it's usually best to check for similar issues in the repo first, and then go ahead and create a PR if it isn't actively being worked on. In the case of Reader, you're generally good to go, because it's only receiving basic maintenance.

Sorry if I wasn't clear - I think we should adjust the display of images specifically in the new posts block so they appear consistently. In particular:

  • the image should not be taller than the current row
  • alignment of the image should be consistent on every row

@sarayourfriend sarayourfriend changed the base branch from master to trunk November 20, 2020 16:12
@github-actions
Copy link

github-actions bot commented May 5, 2021

This PR has been marked as stale due to lack of activity within the last 30 days.

@sixhours
Copy link
Contributor

@tophertoy a much-belated thank you for working on this! Some new styles have been added since this PR opened; the current state looks like this:

Screen Shot 2021-05-13 at 4 31 40 PM

Not great, but not as bad as before. With this PR, we'd lose the bullet points, and I hesitate to do that because they provide some necessary visual separation between each post:

Screen Shot 2021-05-13 at 4 31 48 PM

I'm going to close this out, but please feel free to start a new PR with additional visual improvements based on the latest trunk. Apologies it took so long for us to get back to this!

@sixhours sixhours closed this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. OSS Citizen [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants