-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: style Gutenberg latest post block #44295
Reader: style Gutenberg latest post block #44295
Conversation
1d43c13
to
aa23d6b
Compare
aa23d6b
to
92e6496
Compare
@bluefuton thoughts so far? |
Much improved 👍 Can we investigate what happens with featured images? I notice the penguins on this post are misaligned: http://calypso.localhost:3000/read/blogs/159889361/posts/760 |
@bluefuton yes I can do that. I noticed it's in production too: https://wordpress.com/read/blogs/159889361/posts/760 What is the preferred Automattic process to proceed with a production fix? Do you normally check if someone has raised an issue first and see if anyone is working on it? |
@tophertoy it's usually best to check for similar issues in the repo first, and then go ahead and create a PR if it isn't actively being worked on. In the case of Reader, you're generally good to go, because it's only receiving basic maintenance. Sorry if I wasn't clear - I think we should adjust the display of images specifically in the new posts block so they appear consistently. In particular:
|
This PR has been marked as stale due to lack of activity within the last 30 days. |
@tophertoy a much-belated thank you for working on this! Some new styles have been added since this PR opened; the current state looks like this: Not great, but not as bad as before. With this PR, we'd lose the bullet points, and I hesitate to do that because they provide some necessary visual separation between each post: I'm going to close this out, but please feel free to start a new PR with additional visual improvements based on the latest |
Changes proposed in this Pull Request
This PR deals with just the latest post block from issue: #43595
Working from: https://made4testing0318.blog/2020/04/16/latest-posts-block/
Testing instructions
Taken from: http://calypso.localhost:3000/read/blogs/159889361/posts/1003
Before:
After: