Gutenboarding: get plan from URL param #41679
Conversation
* Update path to include plan. * Introduce plans.ts in gutenboarding lib. * Update PlansButton to use lib/plans and path.
razvanpapadopol
added
[Feature] Plans & Upgrades
| const plan = getPlanSlugByPath( planPath ) || ( hasPaidDomain ? defaultPaidPlan : freePlan ); | ||
|
|
||
| /* translators: Button label where %s is the WordPress.com plan name (eg: Free, Personal, Premium, Business) */ | ||
| const planLabel = sprintf( __( '%s Plan' ), getPlanTitle( plan ) ); |
There was a problem hiding this comment.
I'm not sure about this translation. It's not consistent with what we have over at WordPress.com/plans (both the logged-in page and logged-out marketing pages)
Many locales translate the plan names (Free, Business, and so on). I'm not arguing for one over the other, but for brand consistency, my guess is that we should describe the plans uniformly.
For example, take Japanese:
https://ja.wordpress.com/pricing/
and in Gutenboarding
Same for German, which only translations "Personal"
We already have 100% translation coverage for:
Business Plan
Personal Plan
Premium Plan
Strangely "eCommerce Plan" doesn't yet exist, but there's eCommerce
There was a problem hiding this comment.
If I understood correctly, you suggested taking "Plan" word out of the header? I think it would be important to keep "Plan" word in the header for clarity ("Premium" what?). When plans are side-by-side on a grid, it's more clear that "personal" refers to a plan, but in the header it could refer e.g. to automatically assigned vertical. (@dubielzyk)
I think it's ok to merge this PR without changes to this I think and we can log follow-ups; generally we can bend the rest of the system for designs, vs try to bend designs for the code we happen to have.
There was a problem hiding this comment.
Yeah, let's make the least amount of copy changes for now and I'll follow-up where we should override. We wanna be as consistent with the previous designs as possible
There was a problem hiding this comment.
If I understood correctly, you suggested taking "Plan" word out of the header?
No, just highlighting that we need to be consistent.
We're introducing a new i18n string with __( '%s Plan' ).
Because of this, I think we need to make sure that we use the same nomenclature across our application including marketing pages, or that we follow the existing implementation.
There was a problem hiding this comment.
Fair point. I noted down consistently translating plans at #37665
|
Works as described. A really nice change! I left a note about translations, which I think should be consistent with our marketing copy over at WordPress.com/plans |
Changes proposed in this Pull Reques
planas an optional param./new/PLAN_SLUGwhere the slug isbeginner,personal,premium,business, orecommerce.Testing instructions
/newwill happen but language should be set correctly.Screenshot
Fixes #41576