WPCOM Block Editor: hide Gutenberg preview button #41528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
vindl
reviewed
Apr 28, 2020
andrewserong
approved these changes
Apr 28, 2020
…es don't work on WordPress.com. In v8.0 the class for these element has changed. Let's update the class and keep hiding it!
Keep the existing class for compatibility with older Gutenberg versions
ramonjd
force-pushed
the
update/hide-gutenberg-8.0-preview-button
branch
from
fae411b to
11ffaa6
Compare
|
Backend diff D42601-code |
matticbot
removed
the
[Status] Needs Review
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
We hide the Gutenberg preview dropdown list because the style overrides don't work on WordPress.com. See: #40388
In
v8.0.0-rc.1the class name for this element has changed. Let's update the class and keep hiding it!Testing instructions
Check out this branch and build it:
npx lerna run build --scope='@automattic/wpcom-block-editor' -- -- --watchUpload the files in
apps/wpcom-block-editor/distto your sandbox.YOUR_TEST_SITE_URLshould be running Gutenberg Edge (8.0.0-rc.1)YOUR_TEST_SITE_URLshould be sandboxedTry creating a post:
https://wordpress.com/block-editor/post/[YOUR_TEST_SITE_URL]
Check that the preview button in the editor always defaults always to the mobile version
Fixes #41519