Update product card options alignment and appearance #38344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delawski
added
[Feature] Plans & Upgrades
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Code looks good, but visually the options group on desktop is throwing me off; daily feels too far to the left. I tweaked some CSS in my browser to adjust and got this: https://d.pr/i/JMikhS
Thoughts?
|
@ChaosExAnima It looks good, thanks for that! Feel free to push your changes to this PR - we will review and merge them tomorrow. |
|
Thanks for the link, @ChaosExAnima. I've updated the options horizontal layout according to your suggestions and landed with something like this:
|
tyxla
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work related to p1HpG7-87V-p2, this PR centers the
ProductCardoptions heading, updates its wording and removes the bottom border.Also, a vertical separator between options is added as part of this PR.
Lastly, some minor padding/margin adjustments in the options area are made here so that it all looks good.
Calypso - before
Calypso - after
Jetpack Connect - before
Jetpack Connect - after
Those updates apply to Jetpack Connect flow as well.
Changes proposed in this Pull Request
Testing instructions
Fixes #