Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force GdprBanner not to render in SSR. #34462

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Force GdprBanner not to render in SSR. #34462

merged 1 commit into from
Jul 4, 2019

Commits on Jul 4, 2019

  1. Force GdprBanner not to render in SSR. 

    GdprBanner tries to access certain client-side-only properties, such as
the `cookies` object in document, and navigator.userAgent.

This caused SSR to fail when the component was added to the logged-out
layout.

Since it doesn't make sense to render the GDPR banner on the server
anyway (since we don't have enough information to determine whether it
should be shown), this change effectively disables it whenever the
`document` object isn't present.
    @sgomes
    sgomes committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    04ad36c View commit details
    Browse the repository at this point in the history