Move reader-main to reader/components #28272
Conversation
bluefuton
added
[Status] Needs Review
| @@ -113,6 +113,10 @@ export class FullPostView extends React.Component { | |||
| this.attemptToSendPageView(); | |||
| } | |||
|
|
|||
| if ( this.props.shouldShowComments && ! prevProps.shouldShowComments ) { | |||
There was a problem hiding this comment.
This is an unrelated change - the linter picked up on usage of componentWillReceiveProps in Reader full post.
To test, make sure that a full post URL with #comments suffix still takes you to the comments section of a full post, e.g.:
http://calypso.localhost:3000/read/blogs/140522955/posts/2773#comments
There was a problem hiding this comment.
A suggestion for the future: Lazy loading images can push the scroll of the page further down, moving the comments section off-screen. I'd imagine this could be solved if we had the height information of the images.
bluefuton
force-pushed
the
move/reader-main
branch
from
4e930db to
1429673
Compare
| @@ -113,6 +113,10 @@ export class FullPostView extends React.Component { | |||
| this.attemptToSendPageView(); | |||
| } | |||
|
|
|||
| if ( this.props.shouldShowComments && ! prevProps.shouldShowComments ) { | |||
There was a problem hiding this comment.
A suggestion for the future: Lazy loading images can push the scroll of the page further down, moving the comments section off-screen. I'd imagine this could be solved if we had the height information of the images.
matticbot
removed
the
[Status] Needs Review
Changes proposed in this Pull Request
A number of Reader-specific components and blocks currently live in the main components and blocks directories, even though they are not used elsewhere in Calypso. I feel that these components and blocks should live inside client/reader if they are not likely to be reused outside Reader. See also: #28161.
What's reader-main anyway?
Testing instructions
Load the Reader at http://calypso.localhost:3000 and ensure that all Reader streams have a white background.