-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg Blocks: Rename o2 preset to p2 #27939
Conversation
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
Once this is merged, let's have CircleCI build this preset for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Seems like we still refer to p2
s as to it as o2
s here and there though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of this since the actual theme that this injects into is called o2, plus it's changing things and I don't see a benefit. But whatever. Just saying it seems like a regression to me.
I don't feel super strong about this, so I'm willing to cede this PR. It just seemed to me that we're almost exclusively using 'P2' to refer to those... |
We can prolly close this one. |
Quoting D19603-code
#394021
Testing instructions
Verify that
npm run sdk -- gutenberg client/gutenberg/extensions/presets/p2/
successfully builds files in that folder'sbuild/
subdirectory.