Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg Blocks: Rename o2 preset to p2 #27939

Closed
wants to merge 1 commit into from
Closed

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Oct 18, 2018

Quoting D19603-code #394021

I'd originally meant to call the preset p2 (since that's what most of us intuitively refer to, not o2). However, for automated namespacing of generated CSS, I changed that to o2, since the body element of P2s already had an o2 class (but not a p2 one) -- it was simply more convenient at the time not to add another class.

However, as of #26662, we're no longer auto-namespacing CSS with block/preset names anyway. I meant to rename the preset on the Calypso set for a while (and will proceed to do so now). This phab diff is a good opportunity to also do so on the server side.

Testing instructions

Verify that npm run sdk -- gutenberg client/gutenberg/extensions/presets/p2/ successfully builds files in that folder's build/ subdirectory.

@ockham ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Oct 18, 2018
@ockham ockham self-assigned this Oct 18, 2018
@matticbot
Copy link
Contributor

@ockham ockham requested review from dmsnell and a team October 18, 2018 17:27
@ghost
Copy link

ghost commented Oct 18, 2018

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@ockham
Copy link
Contributor Author

ockham commented Oct 18, 2018

Once this is merged, let's have CircleCI build this preset for us.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Seems like we still refer to p2s as to it as o2s here and there though...

Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this since the actual theme that this injects into is called o2, plus it's changing things and I don't see a benefit. But whatever. Just saying it seems like a regression to me.

@ockham
Copy link
Contributor Author

ockham commented Oct 20, 2018

Not a fan of this since the actual theme that this injects into is called o2, plus it's changing things and I don't see a benefit. But whatever. Just saying it seems like a regression to me.

I don't feel super strong about this, so I'm willing to cede this PR. It just seemed to me that we're almost exclusively using 'P2' to refer to those...

@simison
Copy link
Member

simison commented Apr 3, 2019

We can prolly close this one.

@simison simison closed this Apr 3, 2019
@simison simison deleted the rename/preset-o2-to-p2 branch April 3, 2019 08:50
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants