Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: fix list block indent/outdent functionality #27877

Merged
merged 2 commits into from
Oct 16, 2018

Conversation

vindl
Copy link
Member

@vindl vindl commented Oct 16, 2018

Resolves #27637

We were missing the TinyMCE lists plugin which core tries to import from
a separate js file that's available in the vendor directory.

Testing instructions

  1. Navigate to http://calypso.localhost:3000/gutenberg/post/.
  2. Add a list block and make sure that ident/outdent functionality works.
  3. Make sure that it's working the same as in https://wordpress.org/gutenberg/.

Props @Copons and @dmsnell for tracking down the problem!

We were missing the TinyMCE lists plugin which core tries to import from
a separate js file that's available in the vendor directory.
@vindl vindl added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Oct 16, 2018
@vindl vindl self-assigned this Oct 16, 2018
@vindl vindl requested a review from a team October 16, 2018 14:10
@matticbot
Copy link
Contributor

@ghost
Copy link

ghost commented Oct 16, 2018

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@Copons Copons self-assigned this Oct 16, 2018
Copy link
Contributor

@Copons Copons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! ✨

@vindl vindl removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2018
@Copons Copons modified the milestone: Core Blocks Integration Oct 16, 2018
@vindl vindl merged commit 0f5712e into master Oct 16, 2018
@vindl vindl deleted the fix/gutenberg-list-block branch October 16, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants