Traffic Settings: add Jetpack Search upgrade message #27059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add an upgrade message for Jetpack Search - also for wp.com sites - reorder the traffic settings to put the stuff you may be more likely to toggle higher up
gibrown
added
[Type] Enhancement
[Feature] Site Settings
alisterscott
added
the
[Status] Needs Review
|
Top of traffic tab for Jetpack site:
Top of traffic tab for WP.com site:
|
|
I pushed a commit to address the prop warning. Besides that, the code looks OK to me. We should probably get a design review for the content in the banner since it seems like more than usual. |
ebinnion
added
[Status] Needs Design Review
ebinnion
approved these changes
Sep 7, 2018
eliorivero
reviewed
Sep 11, 2018
| } | ||
|
|
||
| return ( | ||
| <div> | ||
| <div style={ { marginBottom: '16px' } }> |
There was a problem hiding this comment.
This should be moved to a stylesheet.
eliorivero
added
the
[Status] Needs Copy Review
|
I'd tweak the headline: Add faster, more advanced searching to your site with Jetpack Professional In the body copy:
|
gibrown
added
[Status] Needs Review
|
@ebinnion or @eliorivero can I get one last look. Only changes I made were to move the style into into the css sheet and some updates to the wording. @jeffgolenski fyi, @michelleweber helped a bit with some feedback on the wording and I'm going with that. The latest looks like:
I'll use the same wording in the Jetpack PR for an upgrade message. |
…-search-upgrade-msg
gibrown
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an upgrade message in traffic settings where the Jetpack Search settings are displayed once a plan has been purchased.
The messaging is based on Automattic/jetpack#9747
I have also reordered the traffic settings page a bit to adjust which items are on top. Some thoughts behind this:
One question I have here is that I am seeing "Warning: Failed prop type: Invalid prop
descriptionsupplied toBanner." in my console (Chrome). I suspect this has to do with the gnarly html description I have used. Some way around this?