Gutenberg: Fix plugin name of Publicize #26726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Status] Needs Review
This was referenced Aug 16, 2018
|
Hmm, right, difference between |
Not your bad at all - it was me who suggested it initially 😉 #26662 (comment) |
simison
approved these changes
Aug 16, 2018
matticbot
removed
the
[Status] Needs Review
|
Is this something we think is worth flagging as an issue with the upstream project? Why wouldn't plugins have a namespace? |
|
WP plugins don't have namespaces, so I expect Gutenberg plugins would keep consistency with that. But it's also possible that this hasn't been considered, so I've opened an issue to discuss it: WordPress/gutenberg#9080 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like in #26662 we didn't account for the fact that Gutenberg has some limitations on the plugin names. When we have a slash in the plugin name, we'll see the following error:
This PR resolves that.
To test:
Follow the instructions #26603, which contains this PR. Verify you can no longer see the error when you load your Gutenberg editor.