SDK: Fix externalization of the wp global variable #26725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Status] Needs Review
This was referenced Aug 16, 2018
dmsnell
approved these changes
Aug 16, 2018
There was a problem hiding this comment.
feel free to merge this. I think I would probably find it less confusing if we left the wp as its own export instead of adding it into the wordpressRequire and wordpressExternals functions since those kind of have a very specific and uniform function
externals: [
shouldExternalizeWordPress && wordpressExternals,
shouldExternalizeWordPress && 'wp',
'lodash'
]
|
Good point 👍 Updated in 7a3e1fe |
tyxla
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in #26680 we got rid of externalizing
wpas a global variable. This PR brings it back.To test: try #26603, which contains this branch in it. WIthout this commit, the publicize extension no longer builds, as it can't locate the
wpmodule.Also, verify regular Calypso boots correctly like it did before, and is unaffected by this change.