Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: add debug capabilities to getHttpData and fix bug #24735

Merged
merged 1 commit into from
May 8, 2018

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented May 8, 2018

This code is still dormant in production:

  • when window.app.isDebug set then expose httpData functions
  • pass fromApi through to final handler/leave lazy

No real testing. Testing is being done in the development of #24631

This code is still dormant in production:

 - when `window.app.isDebug` set then expose `httpData` functions
 - pass `fromApi` through to final handler/leave lazy
@dmsnell dmsnell added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Data labels May 8, 2018
@matticbot
Copy link
Contributor

@dmsnell dmsnell merged commit 477d7a3 into master May 8, 2018
@dmsnell dmsnell deleted the framework/get-http-data-debug branch May 8, 2018 16:43
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants