Framework: Iterate on getHttpData()
#24656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From feedback in #24631 - Make `fromApi` lazy since it gets called on every render and might be expensive - Allow `fetch` to be lazy for the same reason - Merge `common.js` into `index.js` to consolodate imports
dmsnell
added
Framework
[Status] Needs Review
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From feedback in #24631
Make
fromApilazy since it gets calledon every render and might be expensive
Allow
fetchto be lazy for the same reasonMerge
common.jsintoindex.jsto consolodate importsThere's no real testing instructions since this code is dormant
right now in Calypso. Please focus on the code itself and the
implications of the changes.