Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State: Use getHttpData() for geolocation data #24631

Merged
merged 7 commits into from
May 8, 2018
Merged

State: Use getHttpData() for geolocation data #24631

merged 7 commits into from
May 8, 2018

Commits on May 8, 2018

  1. State: Use getHttpData() for geolocation data 

    In #22549 we added the `getHttpData()` abstraction
for simple network data needs.

In this patch we're moving the `geo` state subtree over to this
new abstraction and removing the old code it previously required.

This approach is build on the data-layer ideas and extends it
to store data outside of Redux.
    @dmsnell
    dmsnell committed May 8, 2018
    Configuration menu
    Copy the full SHA
    688510a View commit details
    Browse the repository at this point in the history

  2. Make fromApi lazy and skip parser creation

    @dmsnell
    dmsnell committed May 8, 2018
    Configuration menu
    Copy the full SHA
    46d2e84 View commit details
    Browse the repository at this point in the history

  3. Fix merge conflict

    @dmsnell
    dmsnell committed May 8, 2018
    Configuration menu
    Copy the full SHA
    9df67f6 View commit details
    Browse the repository at this point in the history

  4. Update getter for thunk fromApi

    @dmsnell
    dmsnell committed May 8, 2018
    Configuration menu
    Copy the full SHA
    d78abea View commit details
    Browse the repository at this point in the history

  5. Update selector test code

    @dmsnell
    dmsnell committed May 8, 2018
    Configuration menu
    Copy the full SHA
    4f36209 View commit details
    Browse the repository at this point in the history

  6. Rename and move files around

    @dmsnell
    dmsnell committed May 8, 2018
    Configuration menu
    Copy the full SHA
    16c766c View commit details
    Browse the repository at this point in the history

  7. Fix bug in getter

    @dmsnell
    dmsnell committed May 8, 2018
    Configuration menu
    Copy the full SHA
    f1f547d View commit details
    Browse the repository at this point in the history