Framework: Remove i18n mixin injections from tests #18471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
force-pushed
the
remove/i18n-mixin-injections
branch
3 times, most recently
from
cccd62e to
82d4b3f
Compare
ockham
force-pushed
the
remove/i18n-mixin-injections
branch
from
82d4b3f to
2957c58
Compare
ockham
force-pushed
the
remove/i18n-mixin-injections
branch
from
721b008 to
85b8e57
Compare
ockham
added
[Status] Needs Review
samouri
reviewed
Oct 3, 2017
| import assert from 'assert'; | ||
| import sinon from 'sinon'; | ||
| import { identity } from 'lodash'; | ||
|
|
||
| /** | ||
| * External dependencies |
|
I don't really know the old paradigm of mixin injection for tests. You are deleting setup code and tests still pass...so seems good to me! |
tyxla
added
[Status] Ready to Merge
and removed
[Status] Needs Review
@samauri I think the reason is simply that
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove i18n mixin injections from tests (and some obsolete
matches-selectorstubs I found while working on this). This PR really only touches test files -- the corresponding units have been usinglocalizealready, only the tests hadn't been updated accordingly yet.Rationale: We're trying to get rid of mixin auto-injection for the React 16 upgrade, since this relies on methods (
react/lib) that aren't part of the public interface.To test: Verify that unit tests pass.
Follow-up PR that tackles
client/auth/test/login.jsxwhich also requires changes to the tested unit.