-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: autoformat all files with calypso-prettier #18282
Conversation
8c74cf3
to
a0df5ab
Compare
a0df5ab
to
4db3aa5
Compare
I ran the e2e tests against the branch and didn't come across any problems. |
4db3aa5
to
12b5f44
Compare
🎉 |
Our selectors DevDocs parsing is pretty naive, and changes here to include https://github.com/Automattic/wp-calypso/blob/master/client/state/selectors/get-site-url.js We could improve selector file parsing (as previously attempted in #10487), but begs the question if we really want the |
I don't think the two items are mutually exclusive. As to the latter, I've written a codemod that can split up the format docblock and the dependencies docblock. Right now the functionality is part of sort-imports but if we want we can isolate the feature |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/2900697 Hi @samouri, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Inspired by: #14801, argued for in #12260 (comment)
Generated by running