Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed Block: Add support for x.com links to embed Twitter posts #81116

Closed
tanjoymor opened this issue Aug 27, 2023 · 9 comments
Closed

Embed Block: Add support for x.com links to embed Twitter posts #81116

tanjoymor opened this issue Aug 27, 2023 · 9 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests

Comments

@tanjoymor
Copy link

What

Users are trying to use the https://x.com URLs to embed tweets and it drops them in as a text link only. Swapping the x.com for twitter.com does work to embed the tweet.

Can this block be updated to work with the x.com URLs? Or maybe add a message stating that they have to use the twitter.com version of the URL?

Why

Right now it just looks like the block is broken and not working properly. It either gives an error:
kDYwGl.png

Or it just posts it as linked text.

How

No response
@tanjoymor tanjoymor added [Type] Feature Request Feature requests [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Aug 27, 2023
@cuemarie
Copy link

cuemarie commented Aug 29, 2023 •
edited
Loading

📌 ACTIONS

@cuemarie cuemarie moved this from Needs Triage to To Do in Automattic Prioritization: The One Board ™ Aug 29, 2023
@cuemarie cuemarie mentioned this issue Aug 29, 2023
Closed
@cuemarie cuemarie added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Aug 29, 2023
@cuemarie cuemarie changed the title Block: Twitter Embed Block: Add support for x.com links to embed Twitter posts Aug 29, 2023
@cuemarie cuemarie added the Triaged To be used when issues have been triaged. label Aug 29, 2023
@sophiegyo
Copy link

Noting another case here: 6694991-zen

@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited
Loading

Support References

This comment is automatically generated. Please do not edit it.

  • 6694991-zen
  • 6805704-zen
  • 6806332-zen
  • 6804730-zen
  • 6981226-zen
  • 8526927-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 30, 2023
@ariel-maidana
Copy link

ariel-maidana commented Sep 12, 2023 •
edited
Loading

Another case here: 6805704-zd-a8c
Please inform the user if this issue is solved: 6806332-zd-a8c

@cuemarie cuemarie added the [Pri] Low Address when resources are available. label Sep 13, 2023
@ariel-maidana
Copy link

Another case here: 6804730-zd-a8c
Please inform the user when this issue is solved.

@chiape
Copy link

chiape commented Sep 27, 2023

6981226-zen

@cuemarie
Copy link

cuemarie commented Sep 27, 2023 •
edited
Loading

WordPress/gutenberg#54876 was merged in Gutenberg 16.8, which checks if the URL points to x.com and replaces it with twitter.com as a fallback to retrieve the embed preview using the Twitter provider.

In other words, this workaround is in the future for WordPress.com sites 👍

@ha-un ha-un mentioned this issue Jun 3, 2024
Open
@kelasante
Copy link
Collaborator

User experiences issue in Classic Editor in 8526927-zen as WordPress/gutenberg#54876 works for only the Block Editor.

Asked user to manually switch from X to twitter to embed as they prefer to keep using the Classic Editor.

@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
@annezazu
Copy link

annezazu commented Sep 9, 2024

Closing this out as WordPress/gutenberg#54876 was merged previously and is available on WordPress.com.

@annezazu annezazu closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ariel-maidana @annezazu @cuemarie @sophiegyo @tanjoymor @chiape @kelasante