Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Layout Dimensions can't be changed #67059

Closed
1 task
msilbers opened this issue Aug 26, 2022 · 17 comments
Closed
1 task

Global Styles: Layout Dimensions can't be changed #67059

msilbers opened this issue Aug 26, 2022 · 17 comments
Assignees
Labels
[Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@msilbers
Copy link

Quick summary

On at least two themes, the Global Styles layout setting does not actually save changes to the dimensions. You can input a new number, but when you hit Save they are set back to default.

Screen Shot 2022-08-26 at 4 41 26 PM

Steps to reproduce

  1. Activate an FSE theme, tested on Blank Canvas and Quadrat
  2. Go to Appearance > Editor
  3. On the top right, select Global Styles
  4. Select Layout
  5. Change the Content or Wide dimensions to anything else, click Save

What you expected to happen

To save new dimensions for the site's content area

What actually happened

The values reverted to what they originally showed

Context

Reported by a customer, reproduced by HE

reported in

  • 5510316-zen

Platform (Simple, Atomic, or both?)

Simple, Atomic

Theme-specific issue?

Applies at least to:

Blank Canvas
Quadrat

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No but the platform is still usable

Workaround details

No response

@msilbers msilbers added [Type] Bug User Report This issue was created following a WordPress customer report [Pri] Normal Schedule for the next available opportuinity. labels Aug 26, 2022
@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Support References

This comment is automatically generated. Please do not edit it.

  • 5510316-zen
  • 5493921-zen
  • 5532506-zen
  • 5588431-zen
  • 5847270-zen

@rw-ye
Copy link

rw-ye commented Aug 28, 2022

Another report here: 5493921-zd-woothemes

Theme: Blank Canvas

@kerrynicl
Copy link

USer report - 36522030 - hc
User unable to remove block spacing, defaults to 1.5 rem

@cuemarie
Copy link

cuemarie commented Sep 1, 2022

📌 SCRUBBING : RESULT

  • Tested on Simple: Replicated
  • Tested on AT: Could Not Replicate
  • Tested on Self-hosted: Could Not Replicate
  • Replicable on Core? Not so far

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Based on my findings below, this issue seems to be site-specific, not theme specific. Take a look:

Testing Round One:

  • AT Site on Quadrat White: Could Not Replicate
  • Simple Site on Blockbase: Replicated
  • Self-Hosted Site on Blank Canvas: Could Not Replicate

Theme Swap:

  • AT Site on Blockbase: Could Not Replicate
    - Simple Site on Quadrat White: Replicated
  • Self-Hosted on Blockbase: Could Not Replicate

➡️ The issue was reproducible, but in my tests, it followed the site, not the theme.

📌 ACTIONS

  • Marked as Triaged for Quality Squad review

@cuemarie cuemarie added Triaged To be used when issues have been triaged. [Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. labels Sep 1, 2022
@dcoleonline
Copy link
Contributor

Another in 5532506-zen

@hanananah
Copy link
Collaborator

Another in 3698984-hc

Meraki theme, but they've tried other themes as well with the same issue

@lunasera41
Copy link

lunasera41 commented Sep 27, 2022

Another in 5588431-zd-woothemes Zoologist theme

@Copons
Copy link
Contributor

Copons commented Nov 1, 2022

@mmtr this looks similar to #67344
Would you mind checking this within the same context?

Note that the initial report mentioned Atomic, but a following comment can't repro anymore.

@mmtr
Copy link
Member

mmtr commented Nov 3, 2022

@Copons Yes, this is the same issue as #67344 which is caused by this Gutenberg bug: WordPress/gutenberg#45520

@msilbers
Copy link
Author

This was reported in 37532163-hc on Appleton theme

@dolgelukkig
Copy link

Another report 38364437-hc theme Payton

@mmtr
Copy link
Member

mmtr commented Dec 9, 2022

This is being fixed upstream in Gutenberg: WordPress/gutenberg#46388

@mmtr
Copy link
Member

mmtr commented Dec 19, 2022

Turns out that WordPress/gutenberg#46388 has fixed #67344 (block gap), but not this issue (dimensions).

@andrewserong I think Gutenberg needs to add more properties to INDIRECT_PROPERTIES_METADATA in order to properly handle the the layout dimensions.

If no one beats me to it, I'll try to look into it tomorrow.

@mmtr mmtr self-assigned this Dec 21, 2022
@mmtr
Copy link
Member

mmtr commented Dec 21, 2022

I opened WordPress/gutenberg#46712 as a fix for this.

@louinel
Copy link

louinel commented Jan 8, 2023

New case in 5847270-zd-woothemes Twenty Twenty-Three theme

@Copons
Copy link
Contributor

Copons commented Jan 9, 2023

Note that we have provided a fix in Core Gutenberg, which is included in Gutenberg 14.9, which should be released on Dotcom this week.

@mmtr
Copy link
Member

mmtr commented Jan 11, 2023

Gutenberg v14.9.1 is now running on all WP.com sites, so this issue should be solved.

@mmtr mmtr closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests