Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: ⨁ plus icon and block toolbar missing in Microsoft Edge 18 #39072

Closed
zdenys opened this issue Jan 25, 2020 · 40 comments
Closed
Assignees
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Impact] High [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended

Comments

@zdenys
Copy link
Contributor

zdenys commented Jan 25, 2020

Steps to reproduce

  1. Starting at URL: Any Post/Page with some Blocks added
  2. Hover over spots in between various Blocks
  3. Select any Block

What I expected

  • See the ⨁ icon appearing to add a Block in that spot
  • See the Block's toolbar above it when any Block is clicked (selected)

What happened instead

No ⨁ is appearing and the toolbar is missing

Browser / OS version

Reproduced in Windows 10 | Edge 18 (BrowserStack)

Screenshot / Video


Link: https://d.pr/i/lgdogS

Context / Source

#painpoint #manual-testing #user-report (generated from p1579963357147800-slack-localized-upwork and in 2659692-zen)

@zdenys zdenys added [Type] Bug When a feature is broken and / or not performing as intended [Goal] Gutenberg Working towards full integration with Gutenberg labels Jan 25, 2020
@Robertght
Copy link

Another case in 2661904-zen

@Robertght
Copy link

As an alternative, I've used the fixed one at the top.

@thesacredpath
Copy link

thesacredpath commented Jan 27, 2020

Another case here: 392564-hud

@geekinthegirl
Copy link

geekinthegirl commented Jan 28, 2020

Had a chat earlier with the same issue: 18230431-hc

Although I was unaware of the fix at the time! They switched to using Firefox instead of Edge, with no issues.

@zdenys zdenys added [Impact] High [Pri] High Address as soon as possible after BLOCKER issues labels Jan 28, 2020
@zdenys
Copy link
Contributor Author

zdenys commented Jan 28, 2020

Another case 2660605-zen.

@retnonindya
Copy link

User report #18006665-hc -- I suggested them to update their Edge browser to the latest version and informed them about displaying Top Toolbar workaround.

@lakellie
Copy link

Another report in 2671311-zen

@catkit
Copy link

catkit commented Jan 29, 2020

The above user asked to get notified when this is fixed. I'm adding this comment so I can let them know it.

@edequalsawesome
Copy link

Also reported in #10215134-hc

@chriskmnds
Copy link
Contributor

We just confirmed this in wp-admin on both WPCOM and local WP install using Edge 18. So this doesn't look like a wp-calypso issue per se, so best reported at https://github.com/WordPress/gutenberg to get more insight. I will follow up with an issue there.

@catkit
Copy link

catkit commented Jan 31, 2020

Another report: #2677182-zen

@GeoJunkie
Copy link
Contributor

Reported in #4268857-hc

Sent the workaround in #2693161-zen

For ease of locating the fix, this is the setting to adjust:


Image Link: https://cldup.com/gbSq4XXYok.png

(h/t @retnonindya for the screenshot)

@tbradsha
Copy link
Contributor

17775546-hc.

@zdenys
Copy link
Contributor Author

zdenys commented Feb 18, 2020

2696122-zen

@zdenys
Copy link
Contributor Author

zdenys commented Feb 18, 2020

18773946-hc

@joweber123
Copy link

18614897-hc

Followup Ticket: 2727121-zen

@zdenys
Copy link
Contributor Author

zdenys commented Feb 19, 2020

13308441-hc

Mentioned the above workaround and also mentioned that the latest iteration of Edge based on Chromium should not have the issue https://support.microsoft.com/en-us/help/4501095/download-the-new-microsoft-edge-based-on-chromium

@GeoJunkie
Copy link
Contributor

Although the Gutenberg issue is closed, it's still happening. Reported in 18512334-hc

@khristiansnyder
Copy link

Another reported in 18807571-hc
Edge 18.18362 on Windows 10.0.0

@lancewillett lancewillett changed the title Block Editor: ⨁ icon and Block toolbar are missing in Microsoft Edge 18 Block Editor: ⨁ plus icon and block toolbar missing in Microsoft Edge 18 Feb 24, 2020
@lancewillett
Copy link
Contributor

This could be a case of merging in the Gutenberg core updates into WordPress.com. CC @ockham @Automattic/luna for an expert opinion

@simison
Copy link
Member

simison commented Feb 24, 2020

Correct — this is fixed in Gutenberg 7.5.0 and we're now on 7.3.0, about to update to 7.4.0.

cc @vindl @ramonjd

@jjchrisdiehl
Copy link
Contributor

@simison Does this mean a fix is on the horizon? I have another case here 2753696-zen

I can also reproduce the issue in Edge, is there an eta on when this issue should be resolved?

@ramonjd
Copy link
Member

ramonjd commented Mar 2, 2020

Does this mean a fix is on the horizon?

It's on the horizon, but we on are on a slow moving ship 🚢 We've had to hold off on upgrading Gutenberg for at least a week until we fix the titles data migration issue. p58i-8E9-p2

@gwwar
Copy link
Contributor

gwwar commented Mar 3, 2020

Instead of waiting, I think it should be possible to add the polyfill as a wpcom customization then remove it when we're ready for the 7.5.0 update

https://github.com/WordPress/gutenberg/pull/20110/files

@kwight
Copy link
Contributor

kwight commented Mar 4, 2020

There's a patch in D39800-code that adds the polyfill to our production Gutenberg v7.3. Having a hard time testing it though – @ramonjd @vindl if someone wants to take a pass at it too 👍

(Hard time, meaning, my access to Edge 18 is Browerstack, and I'm not convinced I'm hitting my sandbox 🙃)

@kwight
Copy link
Contributor

kwight commented Mar 4, 2020

Hard time, meaning, my access to Edge 18 is Browerstack, and I'm not convinced I'm hitting my sandbox

Browserstack has a local testing feature that can force all DNS resolution through your local comp 👍

Screen Shot 2020-03-03 at 4 41 43 PM

@ramonjd
Copy link
Member

ramonjd commented Mar 4, 2020

Hard time, meaning, my access to Edge 18 is Browerstack, and I'm not convinced I'm hitting my sandbox

I have trouble with this too at times 🤕 I tested and could sandbox successfully, but the + icons weren't showing for me with D39800-code applied

Mar-04-2020 12-40-25

Edit: Never mind me. Just saw your comment on D39800-code about the 404

@ramonjd ramonjd closed this as completed Mar 4, 2020
@ramonjd ramonjd reopened this Mar 4, 2020
@ramonjd
Copy link
Member

ramonjd commented Mar 4, 2020

I clicked close accidentally :)

@SiobhyB
Copy link
Contributor

SiobhyB commented Mar 4, 2020

Another report of this issue in 2755126-zen, the user's able to replicate the problem in Edge and Explorer 11. I've suggested the top toolbar option as a workaround for now.

@kwight
Copy link
Contributor

kwight commented Mar 4, 2020

D39800-code is ready for review, to handle simple sites. Atomic will be handled separately.

@kwight
Copy link
Contributor

kwight commented Mar 4, 2020

Correct — this is fixed in Gutenberg 7.5.0 and we're now on 7.3.0, about to update to 7.4.0.

@simison @vindl Just double-checking: we're next moving to 7.4, so another version with the same problem? If this is the case, I wonder if the changes in D39800-code should go in the gutenberg-wpcom plugin then (but they would then need to be removed as part of upgrading to 7.5+).

@gwwar
Copy link
Contributor

gwwar commented Mar 4, 2020

Thanks @kwight D39800-code tests well for me, we can land that ahead of the Atomic side of things if need be.

@kwight
Copy link
Contributor

kwight commented Mar 4, 2020

Fixed for simple sites in D39800-code.

@kwight kwight closed this as completed Mar 4, 2020
@kwight
Copy link
Contributor

kwight commented Mar 4, 2020

Fix deployed for Atomic sites, the release is already live.

@ramonjd
Copy link
Member

ramonjd commented Mar 5, 2020

Unfortunately, I think D39800-code broke a lot of sites

Sorry, I mean the wpcomsh PR

p1583367137051600-slack-CBTN58FTJ

This make the case to upgrade to 7.5.0/7.6.0 as soon as practicable.

cc @Automattic/create

@ramonjd ramonjd reopened this Mar 5, 2020
@ramonjd ramonjd closed this as completed Mar 5, 2020
@gwwar
Copy link
Contributor

gwwar commented Mar 5, 2020

@ramonjd We can make a second attempt tomorrow, we missed a detail for folks using latest Gutenberg.

@gwwar
Copy link
Contributor

gwwar commented Mar 5, 2020

Overall I would recommend keeping up in general since WP core releases pull in latest of Gutenberg.

@ramonjd
Copy link
Member

ramonjd commented Mar 5, 2020

Overall I would recommend keeping up in general since WP core releases pull in latest of Gutenberg.

This has always been the goal.

This iteration has been, however, "special" due to the ongoing data migration for incorrectly encoded titles. :)

@gwwar
Copy link
Contributor

gwwar commented Mar 5, 2020

Reopening, until we sort out the Atomic side of things.

@gwwar gwwar reopened this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Impact] High [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests