Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: i18n for new users #38909

Closed
2 tasks
razvanpapadopol opened this issue Jan 17, 2020 · 9 comments
Closed
2 tasks

Gutenboarding: i18n for new users #38909

razvanpapadopol opened this issue Jan 17, 2020 · 9 comments
Labels
[Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. [Goal] New Onboarding previously called Gutenboarding i18n

Comments

@razvanpapadopol
Copy link

razvanpapadopol commented Jan 17, 2020

When a non logged-in user is going through Gutenboarding we should use the browser language to handle i18n and also suggest an alternate language based on different variables (eg: location, campaign code, other tracking info, etc). locale passed in the URL

Actions:

  • detect browser language (see an experimental PR that introduce this) and possibly extract this as a reusable utility
  • define how to set an alternate locale to suggest to the user
  • [ ] display locale suggestions like in the current signup

Locale detection is already done in the landing page #38909 (comment)

@razvanpapadopol razvanpapadopol added i18n [Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. [Goal] New Onboarding previously called Gutenboarding labels Jan 17, 2020
@johnHackworth johnHackworth mentioned this issue Jan 17, 2020
46 tasks
@simison
Copy link
Member

simison commented Jan 30, 2020

We might actually get away with just having language as URL parameter, much like current /start flow does. I elaborated more in the master issue: #37665

@akirk
Copy link
Member

akirk commented Jan 31, 2020

I'd think it's favorable to keep it the current way. Language selection is harder than it appears and we've got a flow established that works. See also my comment on https://github.com/Automattic/wp-calypso/pull/37756/files#r373471313

@simison
Copy link
Member

simison commented Jan 31, 2020

I'd think it's favorable to keep it the current way.

Yep, I agree and I wrote to that effect in master issue.

Just for clarity, I'll quote you also here from your PR comment:

Traditionally the detection is done on the landing page https://wordpress.com/ that might redirect to localized landing pages which then link to the onboarding with the language as a parameter (e.g. https://wordpress.com/start/fr). We then use the LocaleSuggestions class to offer a switch into the right language.

@simison
Copy link
Member

simison commented Jan 31, 2020

...so basically todo for this issue: we need that kind of language fragments (e.g. /gutenboarding/fr/) and setting UI language to those from the beginning of the flow.

@sirreal
Copy link
Member

sirreal commented Feb 5, 2020

Do we need to support language route parts, or subdomains? es.calypso.localhost:3000/gutenboarding seems to work out of the box with #39282.

@simison
Copy link
Member

simison commented Feb 7, 2020

Do we need to support language route parts, or subdomains?
es.calypso.localhost:3000/gutenboarding seems to work out of the box with #39282.

@akirk do you know answer to this?

@akirk
Copy link
Member

akirk commented Feb 7, 2020

@sirreal How is the language set for logged-out users?

@sirreal
Copy link
Member

sirreal commented Feb 10, 2020

Ignore my question, we won't go with subdomains here.

@sirreal
Copy link
Member

sirreal commented Feb 21, 2020

With #39571, we now use the locale slug from the URL path to localize gutenboarding.

@sirreal sirreal closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. [Goal] New Onboarding previously called Gutenboarding i18n
Projects
None yet
Development

No branches or pull requests

4 participants