-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenboarding: i18n for new users #38909
Comments
We might actually get away with just having language as URL parameter, much like current |
I'd think it's favorable to keep it the current way. Language selection is harder than it appears and we've got a flow established that works. See also my comment on https://github.com/Automattic/wp-calypso/pull/37756/files#r373471313 |
Yep, I agree and I wrote to that effect in master issue. Just for clarity, I'll quote you also here from your PR comment:
|
...so basically todo for this issue: we need that kind of language fragments (e.g. |
Do we need to support language route parts, or subdomains? |
@sirreal How is the language set for logged-out users? |
Ignore my question, we won't go with subdomains here. |
With #39571, we now use the locale slug from the URL path to localize gutenboarding. |
When a non logged-in user is going through Gutenboarding we should use the
browser language to handle i18n and also suggest an alternate language based on different variables (eg: location, campaign code, other tracking info, etc).locale passed in the URLActions:
detect browser language (see an experimental PR that introduce this) and possibly extract this as a reusable utility[ ] display locale suggestions like in the current signupLocale detection is already done in the landing page #38909 (comment)
The text was updated successfully, but these errors were encountered: