Skip to content

Commit

Permalink
Update Playwright to 1.48.2 (#97275)
Browse files Browse the repository at this point in the history
We've been running an old Playwright, which uses Chromium 116 (Aug 2023). Not a great thing for e2e tests.

Trying to bump to a recent one (1.49.1 fails, so I'm guessing a regression). 1.48.2 is Chromium 130 (Oct 2024), so should work and all pass.

We need to manually install browsers now tho: https://github.com/microsoft/playwright/releases/tag/v1.38.0
  • Loading branch information
aidvu authored Dec 11, 2024
1 parent 3a5b61c commit fe04f22
Show file tree
Hide file tree
Showing 4 changed files with 53 additions and 15 deletions.
3 changes: 2 additions & 1 deletion desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,14 @@
"@automattic/calypso-build": "workspace:^",
"@automattic/calypso-eslint-overrides": "workspace:^",
"@electron/notarize": "^2.4.0",
"@playwright/browser-chromium": "1.48.2",
"copy-webpack-plugin": "^10.2.4",
"electron": "26.2.4",
"electron-builder": "23.0.3",
"electron-rebuild": "^2.3.5",
"jest": "^29.7.0",
"lodash": "^4.17.21",
"playwright": "^1.37",
"playwright": "1.48.2",
"postcss": "^8.4.5",
"react": "^18.3.1",
"react-dom": "^18.3.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/calypso-e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,13 @@
"license": "GPL-2.0-or-later",
"dependencies": {
"@jest/types": "^29.5.0",
"@playwright/browser-chromium": "1.48.2",
"@types/totp-generator": "^0.0.3",
"form-data": "^4.0.0",
"jest-docblock": "^29.7.0",
"mailosaur": "^8.4.0",
"nock": "^13.5.4",
"playwright": "^1.37",
"playwright": "1.48.2",
"totp-generator": "^0.0.12"
},
"devDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"@automattic/calypso-e2e": "workspace:^",
"@automattic/jest-circus-allure-reporter": "workspace:^",
"@automattic/languages": "workspace:^",
"@playwright/browser-chromium": "1.48.2",
"@types/archiver": "^5.3.1",
"archiver": "^5.3.0",
"asana-phrase": "^0.0.8",
Expand All @@ -54,7 +55,7 @@
"lodash": "^4.17.20",
"mailosaur": "^8.4.0",
"node-fetch": "^2.6.1",
"playwright": "^1.37",
"playwright": "1.48.2",
"postcss": "^8.3.11"
}
}
59 changes: 47 additions & 12 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ __metadata:
"@automattic/zendesk-client": "workspace:^"
"@jest/globals": "npm:^29.7.0"
"@jest/types": "npm:^29.5.0"
"@playwright/browser-chromium": "npm:1.48.2"
"@types/node": "npm:^22.7.5"
"@types/node-fetch": "npm:^2.6.1"
"@types/totp-generator": "npm:^0.0.3"
Expand All @@ -376,7 +377,7 @@ __metadata:
mailosaur: "npm:^8.4.0"
nock: "npm:^13.5.4"
node-fetch: "npm:^2.6.7"
playwright: "npm:^1.37"
playwright: "npm:1.48.2"
totp-generator: "npm:^0.0.12"
typescript: "npm:^5.3.3"
languageName: unknown
Expand Down Expand Up @@ -5177,6 +5178,15 @@ __metadata:
languageName: node
linkType: hard

"@playwright/browser-chromium@npm:1.48.2":
version: 1.48.2
resolution: "@playwright/browser-chromium@npm:1.48.2"
dependencies:
playwright-core: "npm:1.48.2"
checksum: b65f763b6862883ee177ff859e267ca60f5f3b88f97177cdc799254045c2d55b498fc3074e34d51414d01d04bd2fbbfb4205095d6f33644c22692400c587c755
languageName: node
linkType: hard

"@pmmmwh/react-refresh-webpack-plugin@npm:^0.5.11, @pmmmwh/react-refresh-webpack-plugin@npm:^0.5.15":
version: 0.5.15
resolution: "@pmmmwh/react-refresh-webpack-plugin@npm:0.5.15"
Expand Down Expand Up @@ -10893,6 +10903,7 @@ __metadata:
"@automattic/calypso-build": "workspace:^"
"@automattic/calypso-eslint-overrides": "workspace:^"
"@electron/notarize": "npm:^2.4.0"
"@playwright/browser-chromium": "npm:1.48.2"
archiver: "npm:^3.1.1"
copy-webpack-plugin: "npm:^10.2.4"
cross-env: "npm:^7.0.3"
Expand All @@ -10906,7 +10917,7 @@ __metadata:
js-yaml: "npm:^4.0.0"
lodash: "npm:^4.17.21"
make-dir: "npm:^3.1.0"
playwright: "npm:^1.37"
playwright: "npm:1.48.2"
postcss: "npm:^8.4.5"
react: "npm:^18.3.1"
react-dom: "npm:^18.3.1"
Expand Down Expand Up @@ -18794,6 +18805,16 @@ __metadata:
languageName: node
linkType: hard

"fsevents@npm:2.3.2":
version: 2.3.2
resolution: "fsevents@npm:2.3.2"
dependencies:
node-gyp: "npm:latest"
checksum: be78a3efa3e181cda3cf7a4637cb527bcebb0bd0ea0440105a3bb45b86f9245b307dc10a2507e8f4498a7d4ec349d1910f4d73e4d4495b16103106e07eee735b
conditions: os=darwin
languageName: node
linkType: hard

"fsevents@npm:^2.3.2, fsevents@npm:^2.3.3, fsevents@npm:~2.3.1, fsevents@npm:~2.3.2":
version: 2.3.3
resolution: "fsevents@npm:2.3.3"
Expand All @@ -18804,6 +18825,15 @@ __metadata:
languageName: node
linkType: hard

"fsevents@patch:fsevents@npm%3A2.3.2#optional!builtin<compat/fsevents>":
version: 2.3.2
resolution: "fsevents@patch:fsevents@npm%3A2.3.2#optional!builtin<compat/fsevents>::version=2.3.2&hash=df0bf1"
dependencies:
node-gyp: "npm:latest"
conditions: os=darwin
languageName: node
linkType: hard

"fsevents@patch:fsevents@npm%3A^2.3.2#optional!builtin<compat/fsevents>, fsevents@patch:fsevents@npm%3A^2.3.3#optional!builtin<compat/fsevents>, fsevents@patch:fsevents@npm%3A~2.3.1#optional!builtin<compat/fsevents>, fsevents@patch:fsevents@npm%3A~2.3.2#optional!builtin<compat/fsevents>":
version: 2.3.3
resolution: "fsevents@patch:fsevents@npm%3A2.3.3#optional!builtin<compat/fsevents>::version=2.3.3&hash=df0bf1"
Expand Down Expand Up @@ -26712,23 +26742,27 @@ __metadata:
languageName: node
linkType: hard

"playwright-core@npm:1.37.0":
version: 1.37.0
resolution: "playwright-core@npm:1.37.0"
"playwright-core@npm:1.48.2":
version: 1.48.2
resolution: "playwright-core@npm:1.48.2"
bin:
playwright-core: cli.js
checksum: 1778ba865f1ca5d5022cbaafac3b9cca98ee589171825da81f0408c48b66c7d6ba03ed53ceacb1e79093caa106f57c5e0fbc4bbb42266a4502746e54571bd14b
checksum: 511da53d9df01fec5e5798915c68e7d1574890a504d1aae05430bf538d0080efa8db86e3dafdcd450f084ce7622f6bbede23ca52e798bfc4c3b3ea8da52a51f5
languageName: node
linkType: hard

"playwright@npm:^1.37":
version: 1.37.0
resolution: "playwright@npm:1.37.0"
"playwright@npm:1.48.2":
version: 1.48.2
resolution: "playwright@npm:1.48.2"
dependencies:
playwright-core: "npm:1.37.0"
fsevents: "npm:2.3.2"
playwright-core: "npm:1.48.2"
dependenciesMeta:
fsevents:
optional: true
bin:
playwright: cli.js
checksum: 78a711fe8e7faff8012bd277a8d8dd73faeb795e266d6ce07d07a9c5f9a2333f823dc70813ec34dbf3d3177c84d9c152287c02c3545b4ee33f47a3e716ef14f8
checksum: ecde4ee4767556868b24d7700f3502692a3cb14c8ef127052b51b48833ffcce80942954fb188a9b72505122b48b1b625d1bb486721e1c4f2e980215328ba1ad5
languageName: node
linkType: hard

Expand Down Expand Up @@ -34751,6 +34785,7 @@ __metadata:
"@automattic/jest-circus-allure-reporter": "workspace:^"
"@automattic/languages": "workspace:^"
"@babel/core": "npm:^7.16.0"
"@playwright/browser-chromium": "npm:1.48.2"
"@types/archiver": "npm:^5.3.1"
archiver: "npm:^5.3.0"
asana-phrase: "npm:^0.0.8"
Expand All @@ -34769,7 +34804,7 @@ __metadata:
lodash: "npm:^4.17.20"
mailosaur: "npm:^8.4.0"
node-fetch: "npm:^2.6.1"
playwright: "npm:^1.37"
playwright: "npm:1.48.2"
postcss: "npm:^8.3.11"
webpack: "npm:^5.63.0"
languageName: unknown
Expand Down

0 comments on commit fe04f22

Please sign in to comment.