Enable ECE for shipping subscriptions with free trial and sign up fee #9955
+18
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
asumaran
force-pushed
the
as-fix-ece-shipping-subs-with-free-trial-and-sign-up-fee
branch
from
bb1ee4b to
b3c6d87
Compare
|
Size Change: -7 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
asumaran
requested review from
a team and
cesarcosta99
and removed request for
a team
|
@cesarcosta99 don't worry too much about the amounts in the payment sheet for now, as they'll be addressed later. It would be great if you could confirm that the amounts charged are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9771
Changes proposed in this Pull Request
Enables ECE for subscriptions that require shipping with a free trial and sign-up fee.
Testing instructions
Note
In order to test this PR with the changes in
woocommerce-subscriptions-core(ref) you'd need to clone this repo and symlink the repo to your localsubscriptions-coredirectory inside the WooCommerce Subscriptions plugin:run
npm installandcomposer installif necessary.woocommerce-subscriptions-coreVerify ECE is enabled for case 4
Verify ECE is enabled for case 12
Verify ECE is not enabled for Case 3
Verify ECE is not enabled for Case 11
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge