Add login confirmation check to ECE in Blocks #9944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarcosta99
requested review from
a team and
ricardo
and removed request for
a team
cesarcosta99
changed the title
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +122 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
ricardo
approved these changes
Dec 13, 2024
cesarcosta99
deleted the
fix/9806-ECE-subscription-checkout-signed-out
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9806.
Changes proposed in this Pull Request
This modifies the Blocks implementation of the ECE on-click handler for both regular ECE and tokenized ECE. It adds an initial validation step to check whether login confirmation is required. If confirmation is needed, an alert is displayed. This validation ensures proper handling of guest checkout settings and adjusts the ECE payment flow accordingly. Previously, this check was missing in the Blocks implementation but was already present in the shortcode implementation.
Testing instructions
Test: Ensure ECE works as expected when it's clicked
Transaction is successfully processedmeans you should be able to checkout with ECE as usual.Alert with login redirect is displayedmeans the login confirmation alert should be displayed, not the payment sheet.Test: Ensure tokenized ECE works as expected when it's clicked
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge